[3.14] gh-138514: getpass: restrict echo_char to a single ASCII character (GH-138591)
#138988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acter (pythonGH-138591) This amends commit bf8bbe9 by restricting `echo_char` in `getpass.getpass` to single printable ASCII characters as it would be uncommon to use long strings or multi-byte characters for keyboard feedback. --------- (cherry picked from commit ab6893a) Co-authored-by: Benjamin Johnson <benjohnson2040@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
This was referenced Sep 16, 2025
picnixz
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends commit bf8bbe9 by
restricting
echo_charingetpass.getpassto single printableASCII characters as it would be uncommon to use long strings or
multi-byte characters for keyboard feedback.
(cherry picked from commit ab6893a)
Co-authored-by: Benjamin Johnson benjohnson2040@gmail.com
Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com
Co-authored-by: Brian Schubert brianm.schubert@gmail.com
getpass'secho_charshould be restricted to a single ASCII character #138514📚 Documentation preview 📚: https://cpython-previews--138988.org.readthedocs.build/