Skip to content

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 30, 2025

Takes a CI run from about 8:21 to 6:07.

@brettcannon
Copy link
Member Author

This is a draft until I can verify switching to Arm runners speeds things up; baseline is 8m21s.

@brettcannon brettcannon marked this pull request as ready for review October 30, 2025 22:12
@brettcannon brettcannon added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 30, 2025
@brettcannon brettcannon merged commit ac1ffd7 into python:main Oct 30, 2025
54 checks passed
@brettcannon brettcannon deleted the wasi-ci-arm branch October 30, 2025 22:29
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @brettcannon, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ac1ffd77858b62d169a08040c08aa5de26e145ac 3.14

@miss-islington-app
Copy link

Sorry, @brettcannon, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ac1ffd77858b62d169a08040c08aa5de26e145ac 3.13

@brettcannon brettcannon removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 30, 2025
@skirpichev
Copy link
Contributor

Probably its not a big deal, but after this pr WASI job started failing in CPython forks. An example: https://github.com/skirpichev/cpython/actions/runs/19054675947/job/54423101721?pr=1

@diegorusso
Copy link
Contributor

Probably its not a big deal, but after this pr WASI job started failing in CPython forks. An example: https://github.com/skirpichev/cpython/actions/runs/19054675947/job/54423101721?pr=1

I did a build restoring the version of WASITIME to 38.0.2 and it succeeded. https://github.com/diegorusso/cpython/actions/runs/19098164627/job/54563276302

Then I ran again with WASITIME to 38.0.3 and it still works:
https://github.com/diegorusso/cpython/actions/runs/19098528844/job/54564549223

I'm not sure why it fails in your case.

@hugovk
Copy link
Member

hugovk commented Nov 5, 2025

It's the cache.

The Linux-wasi-sdk-25 cache on your fork is from the 29th (https://github.com/skirpichev/cpython/actions/caches?page=2&query=Linux-wasi-sdk-25), and this PR moved it to ARM on the 30th. Try deleting it and running again.

We could include the architecture in the cache key, but I doubt it's going to change again often, if at all. (Although this is the second time this has come up.)

@skirpichev
Copy link
Contributor

It's the cache.

Thanks, I confirm.

but I doubt it's going to change again often, if at all. (Although this is the second time this has come up.)

I don't think too much people enable CI in forks. So, we don't risk by invalidating too much caches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants