-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Move WASI CI over to Arm runners #140810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move WASI CI over to Arm runners #140810
Conversation
|
This is a draft until I can verify switching to Arm runners speeds things up; baseline is 8m21s. |
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @brettcannon, I could not cleanly backport this to |
|
Sorry, @brettcannon, I could not cleanly backport this to |
|
Probably its not a big deal, but after this pr WASI job started failing in CPython forks. An example: https://github.com/skirpichev/cpython/actions/runs/19054675947/job/54423101721?pr=1 |
I did a build restoring the version of WASITIME to 38.0.2 and it succeeded. https://github.com/diegorusso/cpython/actions/runs/19098164627/job/54563276302 Then I ran again with WASITIME to 38.0.3 and it still works: I'm not sure why it fails in your case. |
|
It's the cache. The We could include the architecture in the cache key, but I doubt it's going to change again often, if at all. (Although this is the second time this has come up.) |
Thanks, I confirm.
I don't think too much people enable CI in forks. So, we don't risk by invalidating too much caches. |
Takes a CI run from about 8:21 to 6:07.