gh-44968: Add "Reload from Disk" feature to IDLE #141574
Conversation
sharktide
left a comment
sharktide
left a comment
There was a problem hiding this comment.
I also don’t think we should restore the cursor position since a file’s line numbers could also change when it is edited and it could cause confusion.
Co-authored-by: R.C.M <sharktidedev@gmail.com>
Removed cursor position restoration logic during file reload.
Rewrote it, now it won't save cursor position. |
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Please rely more on unittest.mock.patch() as well as mock features directly. In addition add a What's New entry in addition to the NEWS entry.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
ashm-dev
requested review from
a team,
1st1,
JelleZijlstra,
ZeroIntensity,
abalkin,
ambv,
asvetlov,
brettcannon,
corona10,
emmatyping,
encukou,
ericsnowcurrently,
erlend-aasland,
ezio-melotti,
freakboy3742,
gaogaotiantian,
hugovk,
kumaraditya303,
lysnikolaou,
markshannon,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
savannahostrowski,
warsaw and
willingc
as code owners
|
The following commit authors need to sign the Contributor License Agreement: |
20 participants
Uh oh!
There was an error while loading. Please reload this page.