Skip to content

gh-142918: Fix Context.items/keys/values docstrings (return iterators, not lists) #142919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyongtao-code wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −13
Open

gh-142918: Fix Context.items/keys/values docstrings (return iterators, not lists) #142919

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
440042f
Fix Context.items/keys/values docstrings (return iterators, not lists)
hyongtao-code Dec 18, 2025
cfe01fd
run PCbuild\amd64\python_d.exe Tools\clinic\clinic.py Python\context.c
hyongtao-code Dec 18, 2025
4a75a78
Update doc of context
hyongtao-code Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Python/clinic/context.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions Python/context.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,12 +650,12 @@ _contextvars.Context.items

Return all variables and their values in the context object.

The result is returned as a list of 2-tuples (variable, value).
The result is returned as an iterator of 2-tuples (variable, value).
[clinic start generated code]*/

static PyObject *
_contextvars_Context_items_impl(PyContext *self)
/*[clinic end generated code: output=fa1655c8a08502af input=00db64ae379f9f42]*/
/*[clinic end generated code: output=fa1655c8a08502af input=f9c1fe4d39962ea0]*/
{
return _PyHamt_NewIterItems(self->ctx_vars);
}
Expand All @@ -664,12 +664,12 @@ _contextvars_Context_items_impl(PyContext *self)
/*[clinic input]
_contextvars.Context.keys

Return a list of all variables in the context object.
Return an iterator of all variables in the context object.
[clinic start generated code]*/

static PyObject *
_contextvars_Context_keys_impl(PyContext *self)
/*[clinic end generated code: output=177227c6b63ec0e2 input=114b53aebca3449c]*/
/*[clinic end generated code: output=177227c6b63ec0e2 input=f806e4e5f77c7e7e]*/
{
return _PyHamt_NewIterKeys(self->ctx_vars);
}
Expand All @@ -678,12 +678,12 @@ _contextvars_Context_keys_impl(PyContext *self)
/*[clinic input]
_contextvars.Context.values

Return a list of all variables' values in the context object.
Return an iterator of all variables' values in the context object.
[clinic start generated code]*/

static PyObject *
_contextvars_Context_values_impl(PyContext *self)
/*[clinic end generated code: output=d286dabfc8db6dde input=ce8075d04a6ea526]*/
/*[clinic end generated code: output=d286dabfc8db6dde input=6f3cb30499d55021]*/
{
return _PyHamt_NewIterValues(self->ctx_vars);
}
Expand Down
Loading