-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-94520: Make CallTips selectable in IDLE #143029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
picnixz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why the splitting algorithm got changed as well and why some tests were removed.
|
|
||
| @unittest.skipIf(MISSING_C_DOCSTRINGS, | ||
| "Signature information for builtins requires docstrings") | ||
| def test_multiline_docstring(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the old tests, the first blank line was used as a separator, and the text after the first blank line was not displayed. However, now that I use the "ScrolledText" widget to display the document. So it is easy to show very long text, so I'm not limit the display to the content before the first blank line.
Do you have any suggestions? Do I need to keep this feature unchanged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, to say:
- Before we only showed partial signature.
- Now we can show the full signature. So old tests are no more needed.
I would advise to keep tests that check whether multiline signatures from builtins are also correctly shown
Misc/NEWS.d/next/IDLE/2025-12-21-07-02-44.gh-issue-94520.lqenne.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. @picnixz Thanks. |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
Misc/NEWS.d/next/IDLE/2025-12-21-07-02-44.gh-issue-94520.lqenne.rst
Outdated
Show resolved
Hide resolved
…e.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
@picnixz Thanks for your advices. I have made the requested changes; please review again. |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
Issue: #94520
The text display widget in the "CalltipWindow" has been changed from "tk.Label" to "ScrolledText", and now the text in the "Calltip" window can be selected with mouse.
The display size of the "CalltipWindow" is set to the smaller value between the size when using the "tk.Label" widget and the default size of "tk.Text".
When the displayed text exceeds the display area of the "ScrolledText" window, showing the vertical scrollbar; otherwise, hiding the scrollbar.
Since more text can be displayed, "argspec" is no longer truncated, and the tests related to the max lines or text truncation have been removed from the unit tests.
I'm sorry for the long delay due to moving house, many data on my computer was lost, it tooks me a very long time to reorganize. But now we can restart.