gh-143195: fix UAF in {bytearray,memoryview}.hex(sep) via re-entrant sep.__len__
#143209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entrant `sep.__len__`
picnixz
force-pushed
the
fix/bytearray/uaf-in-hex-143195
branch
from
64e6922 to
0488d21
Compare
Member
Author
|
Mmh. The memoryview is not entirely fixed. Looks like there is still a UAF but this one doesn't crash with the default build (bytearray crashed without ASAN build but memoryview requires ASAN). I'll fix this as well (I'll need to configure my build with ASAN, which I previously didn't) |
picnixz
force-pushed
the
fix/bytearray/uaf-in-hex-143195
branch
from
a7f98fb to
0b1553f
Compare
picnixz
added
needs backport to 3.13
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2025
…entrant `sep.__len__` (pythonGH-143209) (cherry picked from commit 9976c2b6349a079ae39931d960b8c147e21c6c3f) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Sorry, @picnixz, I could not cleanly backport this to |
|
GH-143219 is a backport of this pull request to the 3.14 branch. |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Dec 27, 2025
…via re-entrant `sep.__len__` (pythonGH-143209) (cherry picked from commit 9976c2b) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-143220 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Py_strhex_implvia re-entrantsep.__len__inbytearray.hex#143195