[3.13] GH-91636: Clear weakrefs created by finalizers. (GH-136401)#144214
Open
sergey-miryanov wants to merge 2 commits intopython:3.13from
Open
[3.13] GH-91636: Clear weakrefs created by finalizers. (GH-136401)#144214sergey-miryanov wants to merge 2 commits intopython:3.13from
sergey-miryanov wants to merge 2 commits intopython:3.13from
Conversation
Member
|
I think this needs re-applying to 3.14 if we're going to do it for 3.13. it was removed (likely temporarily) from 3.14 as a risk mitigation for 3.14.1 (see issue and prs) |
Contributor
Author
|
I understand. At least we have "working" PR for backporting if we decide so :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weakrefs to unreachable garbage that are created during running of finalizers need to be cleared. This avoids exposing objects that have
tp_clearcalled on them to Python-level code. (cherry picked from commit b6b99bf)