-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
GH-144552: Clean up tail-call.yml CI
#144553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-144552: Clean up tail-call.yml CI
#144553
Conversation
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
|
Is this -CC=clang-20 ...
+CC=clang-${{ matrix.llvm }} ... |
Included in savannahostrowski#15, which also combines the Linux steps. |
…-linux Combine Linux steps into one
|
savannahostrowski#16 combines two Windows steps. That will leave us with these Windows jobs: # - target: i686-pc-windows-msvc/msvc
# architecture: Win32
# runner: windows-2022
- target: x86_64-pc-windows-msvc/msvc
architecture: x64
runner: windows-2025-vs2026
build_flags: ""
run_tests: true
- target: x86_64-pc-windows-msvc/msvc-free-threading
architecture: x64
runner: windows-2025-vs2026
build_flags: --disable-gil
run_tests: false
# - target: aarch64-pc-windows-msvc/msvc
# architecture: ARM64
# runner: windows-2022Note Win32 and ARM64 are commented out, and have been since initial commit exactly one year ago! 🎂 cb640b6 Only Windows x64 architecture is run. I suggest we delete the commented code, we can re-add it when we're ready. And after combining two of the three Windows steps into one, we have two remaining: - name: Native Windows MSVC (release)
if: runner.os == 'Windows' && matrix.architecture != 'ARM64'
shell: pwsh
run: |
$env:PlatformToolset = "v145"
./PCbuild/build.bat --tail-call-interp ${{ matrix.build_flags }} -c Release -p ${{ matrix.architecture }}
if ("${{ matrix.run_tests }}" -eq "true") {
./PCbuild/rt.bat -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3
}
# No tests (yet):
- name: Emulated Windows Clang (release)
if: runner.os == 'Windows' && matrix.architecture == 'ARM64'
shell: pwsh
run: |
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.0
$env:PlatformToolset = "clangcl"
$env:LLVMToolsVersion = "${{ matrix.llvm }}.1.0"
$env:LLVMInstallDir = "C:\Program Files\LLVM"
./PCbuild/build.bat --tail-call-interp -p ${{ matrix.architecture }}I don't think that second one has ever been run? I suggest we delete that too. And when we're ready, we can re-add as needed. And that might be by combining into the first Windows step instead of a standalone one. The |
…-windows Combine Windows steps into one
|
Thanks for the pulls @hugovk! I was initially trying to be somewhat conservative but I'm inclined to remove the unused job and commented out platforms as well. I think it'll be obvious enough if/when we need to add them back in. |
|
savannahostrowski#17 removes the duplicate |
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
And let's also backport. |
|
Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @savannahostrowski, I could not cleanly backport this to |
|
Sorry, @savannahostrowski, I could not cleanly backport this to |
(cherry picked from commit 30cfe6e) Co-authored-by: Savannah Ostrowski <savannah@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-144683 is a backport of this pull request to the 3.14 branch. |
3.14 cannot use VS2026 (PlatformToolSet v145) for a tailcalling build. The necessary changes are only in 3.15 (#139922) So on 3.14 we can only use clang (or just omit it to save CI). |
Co-authored-by: Savannah Ostrowski <savannah@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>


Uh oh!
There was an error while loading. Please reload this page.