Skip to content

Fix: ensure unpacked **kwargs have string-compatible keys (#20706) #20713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vikash-Kumar-23 wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −0
Open

Fix: ensure unpacked **kwargs have string-compatible keys (#20706) #20713

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba9380d
Fix: ensure unpacked **kwargs have string-compatible keys (#20706)
Vikash-Kumar-23 Feb 1, 2026
12db980
Refine: allow Any/Unbound types in dict unpacking to avoid false posi…
Vikash-Kumar-23 Feb 1, 2026
05366f5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5432,6 +5432,16 @@ def visit_dict_expr(self, e: DictExpr) -> Type:
expected_types: list[Type] = []
for key, value in e.items:
if key is None:
# This is a **expr unpacking. Check that the expression has string keys.
value_type = get_proper_type(self.accept(value))
# NEW: Allow Any or Unbound types to reduce false positives in external libraries
if isinstance(value_type, (AnyType, UnboundType)):
pass
elif not self.is_valid_keyword_var_arg(value_type):
is_mapping = is_subtype(
value_type, self.chk.named_type("_typeshed.SupportsKeysAndGetItem")
)
self.msg.invalid_keyword_var_arg(value_type, is_mapping, value)
args.append(value)
expected_types.append(
self.chk.named_generic_type("_typeshed.SupportsKeysAndGetItem", [kt, vt])
Expand Down
Loading