PEP 661: Some changes after submission (before SC review) #4232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids breaking code using the existing "sentinels" PyPI package.
taleinat
force-pushed
the
pep-661-after-submission-changes
branch
from
76d90f0 to
a54b989
Compare
AA-Turner
reviewed
Jan 26, 2025
5 tasks
JelleZijlstra
approved these changes
Jan 26, 2025
warsaw
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the suggestion further by making it more opinionated: remove the options to customize the repr and the truthiness.
Use "sentinellib" rather than "sentinels" for the proposed module name, to avoid clashing with an existing popular package on PyPI.
Also a few minor tweaks to wording.
📚 Documentation preview 📚: https://pep-previews--4232.org.readthedocs.build/