Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Feb 24, 2025

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4281.org.readthedocs.build/pep-0775/

StanFromIreland and others added 3 commits February 24, 2025 17:09
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@hugovk
Copy link
Member

hugovk commented Feb 24, 2025

GitHub Markdown tip: when adding an x, if you remove the space inside the square brackets, it'll render it as a checked checkbox. This:

* [ x] abc
* [x] def

Renders as:

  • [ x] abc
  • def

@AA-Turner
Copy link
Member

Just for personal interest, is there a link to the discussion that preceeded creating this PEP? I hadn't realised there was going to be one for this change!

A

@hugovk hugovk changed the title PEP 775 (new): Make zlib required to build Python PEP 775: Make zlib required to build Python Feb 25, 2025
@encukou
Copy link
Member

encukou commented Feb 25, 2025

There is, https://discuss.python.org/t/23062 as linked in Post-History.
The SC could probably allow this change without a PEP, but it's a good way to summarize the discussion.

@encukou encukou added the new-pep A new draft PEP submitted for initial review label Feb 25, 2025
@StanFromIreland
Copy link
Member Author

@hugovk any reason to change the title? (new) is a good clarification that it is not to do with an existing pep?

StanFromIreland and others added 2 commits February 25, 2025 16:37
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Feb 25, 2025

This is our custom and what the template asks for:

  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header

We have a new-pep A new draft PEP submitted for initial review label for new PEPs.

Running pep next with https://github.com/hugovk/pepotron won't pick up the custom title and will suggest 775 again.

@StanFromIreland StanFromIreland marked this pull request as ready for review February 26, 2025 08:25
@StanFromIreland StanFromIreland requested a review from a team as a code owner February 26, 2025 08:25
StanFromIreland and others added 3 commits February 27, 2025 19:01
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@hugovk hugovk changed the title PEP 775: Make zlib required to build Python PEP 775: Make zlib required to build CPython Mar 1, 2025
@AA-Turner AA-Turner merged commit 46e9a4c into python:main Mar 1, 2025
5 checks passed
@AA-Turner
Copy link
Member

Thanks! Please now create a new PEP discussion thread on Discourse, and open a new PR here to update Post-History and Discussions-To @StanFromIreland

A

@StanFromIreland StanFromIreland deleted the pep-775 branch March 1, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants