PEP 768: Add some clarifications and minor edits #4284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC: @warsaw @godlygeek |
Member
Author
pablogsal
force-pushed
the
main
branch
2 times, most recently
from
164d801 to
20ca63e
Compare
godlygeek
reviewed
Feb 26, 2025
This makes it clearer that it is the end user's responsibility to arrange for the file to still be valid even if the process calling `remote_exec` dies before the remote process tries to read the file. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Co-authored-by: ivonastojanovic <80911834+ivonastojanovic@users.noreply.github.com>
pablogsal
commented
Feb 27, 2025
warsaw
reviewed
Mar 4, 2025
warsaw
approved these changes
Mar 4, 2025
Member
warsaw
left a comment
warsaw
left a comment
There was a problem hiding this comment.
LGTM, and thanks! I noticed just one minor misspelling.
pablogsal
commented
Mar 4, 2025
Member
Author
|
Thanks @warsaw ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.