Conversation
|
Congratulations on the acceptance of the PEP! 🥳 While reading again I noticed a small issue: Lines 878 to 880 in a9f1b15 For one, that link is not working (would need to be |
|
Good catch, I'll change the link to the PR with what I ended up implementing. |
| is set only when module execution is complete. This is obviously | ||
| unintuitive. |
There was a problem hiding this comment.
This is perhaps not important anymore now that the PEP is accepted, but you might want to change this sentence, given that the "obviously unintuitive" behaviour is now what PEP 749 implements.
There was a problem hiding this comment.
It's not what's currently implemented.
Discussions-TothreadPEP 123: Mark as Accepted)Statuschanged toAccepted/RejectedResolutionfield points directly to SC/PEP Delegate official acceptance/rejected post, including the date (e.g.`01-Jan-2000 <https://discuss.python.org/t/12345/100>`__)Discussions-To,Post-HistoryandPython-Versionup to datecc @warsaw
📚 Documentation preview 📚: https://pep-previews--4406.org.readthedocs.build/