PEP 8: Add an exmple for blank lines between groups of imports#4433
Closed
tiagoboldt wants to merge 1 commit intopython:mainfrom
Closed
PEP 8: Add an exmple for blank lines between groups of imports#4433tiagoboldt wants to merge 1 commit intopython:mainfrom
tiagoboldt wants to merge 1 commit intopython:mainfrom
Conversation
Member
|
-0; I don't think this is needed. There's not much else this line could be interpreted as. Consider this non-blocking if another editor wants to merge, though. A |
Contributor
|
-0.5, also non-blocking but I don't really see the need to have examples of everything. If someone wants to make a separate page somewhere with good and bad examples for everything, sure, but it doesn't need to be part of the main document (and doesn't even need to be anything official - it could just be a page on the Python wiki or something). |
Member
|
@tiagoboldt Thanks for the contribution, but I agree with the other comments. Not everything needs an example, and adding more text to the PEP can detract from its overall readability. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 8 mentions that a white line should be included between import types, but does not provide an example for it. People quickly browsing the documentation might overlook this detail. Adding an example ensures readers visualize this recommendation.
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4433.org.readthedocs.build/