Skip to content

Comments

PEP 791: address PEP review comments (part 2)#4522

Merged
vstinner merged 2 commits intopython:mainfrom
skirpichev:pep791-edits
Aug 8, 2025
Merged

PEP 791: address PEP review comments (part 2)#4522
vstinner merged 2 commits intopython:mainfrom
skirpichev:pep791-edits

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Aug 5, 2025

  • emphasize: no backward-incompatible changes
  • expand history of the proposal
  • Motivation: what people should expect about factorial() output?
  • add n_div() proposal, rename ceil_div() like gmpy2
  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4522.org.readthedocs.build/pep-0791/

* emphasize: no backward-incompatible changes
* expand history of the proposal
* Motivation: what people should expect about factorial() output?
* add n_div() proposal, rename ceil_div() like gmpy2
@skirpichev skirpichev requested a review from vstinner as a code owner August 5, 2025 16:28
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev
Copy link
Member Author

Once merged, I'll update PEP discussion thread, as suggested in #4430 (comment)

@vstinner vstinner merged commit be15a36 into python:main Aug 8, 2025
5 checks passed
@vstinner
Copy link
Member

vstinner commented Aug 8, 2025

Merged, thanks.

@skirpichev skirpichev deleted the pep791-edits branch August 8, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants