PEP 7: Reword & split the "C dialect" section#4557
Merged
encukou merged 5 commits intopython:mainfrom Aug 27, 2025
Merged
Conversation
The motivation here is to avoid users reading PEP 7 as guarantees about what compilers/settings are required to build Python or extensions. I've also clarified a few things in line with current practice.
encukou
commented
Aug 21, 2025
AA-Turner
reviewed
Aug 21, 2025
AA-Turner
approved these changes
Aug 21, 2025
Member
|
Alliterative and approved! A |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Member
Author
|
@warsaw & @gvanrossum, do you have thoughts on this? |
gvanrossum
reviewed
Aug 22, 2025
Member
gvanrossum
left a comment
There was a problem hiding this comment.
Good improvements overall!
There were two places where I didn't understand what you meant.
I also find it slightly odd to write prescriptive language (e.g. "should be compatible") while at the same time defending that with"but the intro allows exceptions". I'd rather weaken the language somewhat ("ought to"?), in the sake of clarity.
hugovk
reviewed
Aug 25, 2025
gvanrossum
approved these changes
Aug 25, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
gvanrossum
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation here is to avoid users reading PEP 7 as guarantees about what compilers/settings are required to build Python or extensions.
I've also clarified a few things in line with current practice. (And I couldn't resist some alliteration, lmk if suit & tie is required.)
📚 Documentation preview 📚: https://pep-previews--4557.org.readthedocs.build/pep-0007/