Add deterministic ordering by id to review recap views #4538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposals with the same score were appearing in non-deterministic order in the review system recap views. Added secondary sort by `id` to both the grants recap view and proposals recap view to ensure consistent ordering. Fixes #4535 Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4538 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 352 352
Lines 10162 10162
Branches 738 738
=======================================
Hits 9596 9596
Misses 468 468
Partials 98 98 🚀 New features to boost your workflow:
|
marcoacierno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposals with the same score were appearing in non-deterministic order in the review system recap views. Added secondary sort by
idto both the grants recap view and proposals recap view to ensure consistent ordering.Fixes #4535
Generated with Claude Code