Summary: Add context when LLMModule load fails to aid in debugging #16174
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16174
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ace9a45 with merge base 8511b30 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
psiddh
force-pushed
the
error_context
branch
from
0b93858 to
e9f73da
Compare
…ils to aid in debugging/triaging Test Plan: Reviewers: Subscribers: Tasks: Tags:
psiddh
force-pushed
the
error_context
branch
from
e9f73da to
ace9a45
Compare
psiddh
changed the title
|
|
||
| if (model_type_category_ == MODEL_TYPE_CATEGORY_MULTIMODAL) { | ||
| return static_cast<jint>(multi_modal_runner_->load()); | ||
| result = static_cast<jint>(multi_modal_runner_->load()); |
There was a problem hiding this comment.
Thanks Sid for the changes, noob q, can we map and convert the int code to something readable here?
There was a problem hiding this comment.
Yes that is the idea, by integrating with the API: throwExecutorchException(..) (This is the support that was added few months back in the standard ET Android Modules), this carries rich context on the failure and propagates it all the way to the App in the form of ExecutotchRuntimeException . We also log this error to logcat (just in case), we can use the same error message from exception to show alert dialogs or surface it to the user however the Apps wish.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Summary
[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.
[PLEASE REMOVE] If this PR closes an issue, please add a
Fixes #<issue-id>line.[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.
Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.