Update ScalarToTensorPass to correctly track the modified bit #16231
+52
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJessop
requested review from
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16231
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 PendingAs of commit 2e7d7dd with merge base 9d257c8 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
This PR needs a
|
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
2317f5b to
fcbc41c
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
fcbc41c to
6afcfe0
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
6afcfe0 to
26ca6a8
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 21, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
26ca6a8 to
b91ae80
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 21, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 21, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
2 times, most recently
from
cc4d69c to
746664f
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 21, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
746664f to
489fdd4
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 27, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit. Reviewed By: hsharma35 Differential Revision: D89085647
Contributor
|
@larryliu0820 @JacobSzwejbka could we get eyes on this please? :) |
abeakkas
approved these changes
Jan 30, 2026
Contributor
abeakkas
left a comment
abeakkas
left a comment
There was a problem hiding this comment.
Approved with comments on Phabricator.
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit. Also updated test_export_scalar_to_tensor_pass. to_edge already implicitly ran the pass, so the additional pass was idempotent. The updated test manually constructs a graph, checks that the pass modified the graph via graph examination and running the interpreter to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
489fdd4 to
2e7d7dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph.
Also updated test_export_scalar_to_tensor_pass. to_edge already implicitly ran the pass, so the additional pass was idempotent. The updated test manually constructs a graph, checks that the pass modified the graph via graph examination and running the interpreter to check for numerical correctness.
Differential Revision: D89085647