NXP backend: Unify ExecuTorch and Neutron data format enums. #17066
+250
−251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally, the NXP backend used the
NodeFormatenum to mark data formats (memory layouts) of ExecuTorch nodes, and theTensorFormatenum was used to mark the formats for Neutron IR tensors. However, these two classes fundamentally represent the same thing, and there is no need to keep them separated. Additionally, sometimes it was confusing as for which class to use which could result (and has resulted) in bugs.This PR unifies these 2 enums into 1.
Test plan
N/A
cc @robert-kalmar @JakeStevens @digantdesai