Skip to content

Conversation

@jnsiemer
Copy link
Member

@jnsiemer jnsiemer commented Jan 9, 2026

Description

This PR...

  • fixes the implementation of MatZq::inverse_prime and adds tests to avoid this bug
  • adds a benchmarks for MatZq::inverse,
  • avoids warnings for benchmarking by commenting out a benchmarking section.

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide

@jnsiemer jnsiemer requested a review from 3pmile January 9, 2026 14:42
@jnsiemer jnsiemer self-assigned this Jan 9, 2026
@jnsiemer jnsiemer added bug🐛 Something isn't working hotfix🔥 This issue or PR implements an important change and should be worked on quickly labels Jan 9, 2026
@jnsiemer jnsiemer merged commit 26f686b into dev Jan 9, 2026
2 checks passed
@jnsiemer jnsiemer deleted the bug_fix_matzq_inverse branch January 9, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug🐛 Something isn't working hotfix🔥 This issue or PR implements an important change and should be worked on quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants