Support memory slicing

[wtdcode]

Checklist

Which kind of PR do you create?

• This PR only contains minor fixes.
• This PR contains major feature update.
• This PR introduces a new function/api for Qiling Framework.

Coding convention?

• The new code conforms to Qiling Framework naming convention.
• The imports are arranged properly.
• Essential comments are added.
• The reference of the new code is pointed out.

Extra tests?

• No extra tests are needed for this PR.
• I have added enough tests for this PR.
• Tests will be added after some discussion and review.

Changelog?

• [] This PR doesn't need to update Changelog.
• Changelog will be updated after some proper review.
• Changelog has been updated in my PR.

Target branch?

• The target branch is dev branch.

One last thing

• I have read the contribution guide

---

This is one of several efforts to make the current wrapper more pythonic to fix unicorn-engine/unicorn#201.

This PR makes ql.mem support slicing.

[elicn]

Great idea!

[LukeSerne]

This line returns an int, not bytearray, which is somewhat counterintuitive, inconsistent with the case where a slice is given as argument, and goes against the type annotation. I think you should remove the [0]. Also, I'm not sure why this code uses self.ql.mem instead of self. In this class, they reference / point to the same thing, right?

Suggested change

	return self.ql.mem.read(key, 1)[0]
	return self.read(key, 1)

[wtdcode]

This line returns an int, not bytearray, which is somewhat counterintuitive. I think you should remove the [0].

Because we (try to) provide the same interface as bytearray, e.g.:

In [1]: a = bytearray(b"\x01\x02")

In [2]: type(a[0])
Out[2]: int

In [3]:

Also, I'm not sure why this code uses self.ql.mem instead of self. In this class, they reference / point to the same thing, right?

Good point.