Merged
Conversation
7 tasks
Member
|
@ucgJhe - you are welcome to comment. |
Collaborator
|
@HackingFrogWithSunglasses Thanks for your contribution, add some tests for Qdb will make this PR even better. |
Contributor
Author
|
Hey, Thanks for your positive feedback, I really appreciate it. Unfortunately, I simply don't have the time to refine this PR to the way in which you may like. I am also not the best placed person to do this, as I am not a developer. I simply decided to upstream these changes because I felt like other might want them. You are absolutely welcome to adapt the PR and use it, or not. I am fine with either way :) |
Member
|
Hey, welcome to Qiling. I will merge as per advice from @ucgJhe, thank you! |
xwings
approved these changes
Sep 23, 2022
kabeor
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #1217 - here is the x86_64 Qdb support
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing