-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add test for the add_dd_and_align_right in 2D GHZ state generation #7793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shashwatk1998
wants to merge
12
commits into
quantumlib:main
Choose a base branch
from
shashwatk1998:ghz2d
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−20
Open
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b1da71b
Add 2D GHZ state generation
7c6fb6c
Fix imports, docstrings, exposed to __init__, and a mock graph
2fee8d9
spelling
aba5ff5
Fix #7784: Add test for add_dd_and_align_right
3072fb0
Merge branch 'main' into ghz2d
d6fcdcf
Simplified the test
0782ab1
rewrote the test without mocking and stratified restructured
62a963c
Merge branch 'main' into ghz2d
e8b70cb
lint
730abcf
Merge branch 'main' into ghz2d
shashwatk1998 52140b5
Rewrite without one-use helpers and non-shared module variables
pavoljuhas 69dca5d
Capitalize module constants and add type annotations
pavoljuhas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rewrite this test without mocking?
For example, you could compare the circuits produced with and without the dynamical decoupling and check that the extra operations added by the dd have expected gate kinds.