Skip to content

Conversation

@mhucka
Copy link
Collaborator

@mhucka mhucka commented Jan 19, 2026

This updates the inclusion rules in MANIFEST.in.

With the current configuration, the sdist tarball ends up with basically everything, so we end up without anything to add explicitly, and instead, only have to exclude things via rules MANIFEST.in.

Note: #985 needs to be applied first.

@github-actions github-actions bot added the size: S 10< lines changed <50 label Jan 19, 2026
@mhucka mhucka marked this pull request as ready for review January 19, 2026 04:13
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates MANIFEST.in to switch from an inclusion-based to an exclusion-based approach for defining the contents of the source distribution. While the new exclusion rules are beneficial for creating a clean sdist, removing the existing inclusion rules is problematic. It appears to be based on the incorrect assumption that setuptools includes all version-controlled files by default. Without a tool like setuptools-scm, this is not the case, and removing the include and graft directives will result in a broken source distribution missing essential build files. My review provides a corrected version of MANIFEST.in that combines the necessary inclusion rules with the new (and some additional) exclusion rules to ensure the package remains buildable from source.

`setuptools-scm` will not include compiled Python files, cache files, or
other things anyway, so no need to have explicit exclusions for them.
@github-actions github-actions bot added Size: XS <10 lines changed and removed size: S 10< lines changed <50 labels Jan 19, 2026
@mhucka mhucka added this pull request to the merge queue Jan 20, 2026
Merged via the queue into quantumlib:main with commit bdb414a Jan 20, 2026
28 checks passed
@mhucka mhucka deleted the mh-update-manifest branch January 20, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants