Skip to content

Comments

Defer error chain next_node creation#191

Merged
noajshu merged 1 commit intomainfrom
noajshu-patch-3
Feb 22, 2026
Merged

Defer error chain next_node creation#191
noajshu merged 1 commit intomainfrom
noajshu-patch-3

Conversation

@noajshu
Copy link
Contributor

@noajshu noajshu commented Feb 22, 2026

Try and optimize arena allloc by deferring it until it is guaranteed to be needed (i.e. since many nodes get pruned by beam, no_revisit_dets, etc. etc. in between)

For context, I am hunting down something that looks like a memory leak right now in Tesseract. This popped up as a possible factor but I have not yet measured the impact on memory (or runtime for that matter). But wanted to get advice on it.

Try and optimize arena allloc by deferring it until it is guaranteed to be needed (i.e. since many nodes get pruned by beam, no_revisit_dets, etc. etc. in between)

For context, I am hunting down something that looks like a memory leak right now in Tesseract. This popped up as a possible factor but I have not yet measured the impact on memory (or runtime for that matter). But wanted to get advice on it.
@noajshu noajshu requested a review from a team as a code owner February 22, 2026 06:20
@noajshu noajshu requested review from viathor and removed request for a team February 22, 2026 06:20
Copy link
Collaborator

@LalehB LalehB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noajshu noajshu changed the title Defer error chain node creation Defer error chain next_node creation Feb 22, 2026
@noajshu noajshu merged commit bf2e4a4 into main Feb 22, 2026
8 checks passed
@noajshu noajshu deleted the noajshu-patch-3 branch February 22, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants