Fix: Vertical alignment div has no effect for pdf output#13658
Open
MBe-iUS wants to merge 11 commits intoquarto-dev:mainfrom
Open
Fix: Vertical alignment div has no effect for pdf output#13658MBe-iUS wants to merge 11 commits intoquarto-dev:mainfrom
MBe-iUS wants to merge 11 commits intoquarto-dev:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Default setting in function VAlignValidated for minipage is "top". This is now preset and needs to be reflected in the snapshot file.
Collaborator
|
@cderv This looks good to merge for 1.9 from my read. Can you confirm? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #9109.
This PR fixes the vertical alignment problem in Div's with Latex format.
The problem was diagnosed in #9109 and related to the change in layout handling.
The fix simply converts the new layout class properties
quarto-layout-valign-{top,center, bottom}to the Latex pendants{top,center, bottom}.Checklist
I have (if applicable):