Fix dark mode sentinel for saturated brand colours (#14084)#14085
Open
gordonwoodhull wants to merge 1 commit intomainfrom
Open
Fix dark mode sentinel for saturated brand colours (#14084)#14085gordonwoodhull wants to merge 1 commit intomainfrom
gordonwoodhull wants to merge 1 commit intomainfrom
Conversation
…4084) The dark/light sentinel used HWB blackness() which returns 0% for colours like blue (#0000FF), incorrectly classifying them as light. For HTML dual-theme builds, inject literal /*! dark */ and /*! light */ comments from the TS pipeline which knows the theme at build time. For HTML single-theme and RevealJS, use oklch perceptual lightness (color.channel($bg, "lightness", $space: oklch) < 50%) which correctly identifies perceptually dark colours regardless of saturation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mcanouil
reviewed
Feb 22, 2026
Collaborator
mcanouil
left a comment
mcanouil
left a comment
There was a problem hiding this comment.
I've tried on my real example and this seems to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#0000FF)blackness($body-bg)which returns 0% for blue, incorrectly classifying dark themes as light/*! dark *///*! light */comments are now injected from the TypeScript pipeline which knows the theme at build timecolor.channel($bg, "lightness", $space: oklch) < 50%) which correctly identifies dark colours regardless of saturationCloses #14084
Test plan
quarto-dark)data-modeattributes correct)body.quarto-dark, dark syntax highlighting)🤖 Generated with Claude Code