Skip to content

Comments

Integrate 1.3 and 1.4 LUA/AST changes #1166

Closed
cwickham wants to merge 12 commits intomainfrom
issues/8301
Closed

Integrate 1.3 and 1.4 LUA/AST changes #1166
cwickham wants to merge 12 commits intomainfrom
issues/8301

Conversation

@cwickham
Copy link
Collaborator

Mostly a moving of existing content in pre-release highlights into more permanent homes.

Closes quarto-dev/quarto-cli#7900
Closes quarto-dev/quarto-cli#8301

| `quarto.Callout(tbl)` | Callout: `tbl` is a table with entries `type`, `title`, and `content`. |
| `quarto.Tabset(tbl)` | Tabset: `tbl` is a table with entries `tabs`, `level` and `attr`. |
| `quarto.ConditionalBlock(tbl)` | Conditional block: `tbl` is a table with entries `node`, `behavior`, and `condition`. |
| `quarto.FloatRefTarget(tbl)` | Cross-referencable element: `tbl` is a table with entries `content`, `caption_long`, and `caption_short`. |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cscheid I deduced the parameter here from the codebase. Did I get it right?

Copy link
Collaborator

@cderv cderv Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can take more and we do document more in quarto-ast.qmd
Example at: https://github.com/quarto-dev/quarto-cli/blob/7f84537a8dd84859ac7ff0578411e3e26eee249a/src/resources/filters/layout/html.lua#L74-L82

Maybe we can ask claude code to extract info from codebase ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've improved this table with some help from Claude. I'm going to merge to prerelease because this PR has been dragging on too long. We can make fixes before it hits main if needed.

@github-actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-1166.quarto.org

@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 19:57 Inactive
@cwickham cwickham requested a review from cscheid June 18, 2024 20:01
@cwickham cwickham marked this pull request as ready for review June 18, 2024 20:45
@cwickham
Copy link
Collaborator Author

Now also closes quarto-dev/quarto-cli#4499

@github-actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-1166.quarto.org

@github-actions github-actions bot temporarily deployed to pull request June 25, 2024 20:00 Inactive
@cderv
Copy link
Collaborator

cderv commented Nov 18, 2025

@cwickham As I was looking at adding some 1.3 highlight still hidden (https://quarto.org/docs/prerelease/1.3/pdf.html) I found this one still open.

We should probably rework on this one. Those documentation are important to be in main website.

@cwickham
Copy link
Collaborator Author

@cderv Yes, happy to get this merged. Would you review it?

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I am thinking we could ask claude code to give us its thought on the coverage of custom node argument. It does not see straightforward to day to know all the possibly entry. This require some code scanning for Lua file.

| `quarto.Callout(tbl)` | Callout: `tbl` is a table with entries `type`, `title`, and `content`. |
| `quarto.Tabset(tbl)` | Tabset: `tbl` is a table with entries `tabs`, `level` and `attr`. |
| `quarto.ConditionalBlock(tbl)` | Conditional block: `tbl` is a table with entries `node`, `behavior`, and `condition`. |
| `quarto.FloatRefTarget(tbl)` | Cross-referencable element: `tbl` is a table with entries `content`, `caption_long`, and `caption_short`. |
Copy link
Collaborator

@cderv cderv Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can take more and we do document more in quarto-ast.qmd
Example at: https://github.com/quarto-dev/quarto-cli/blob/7f84537a8dd84859ac7ff0578411e3e26eee249a/src/resources/filters/layout/html.lua#L74-L82

Maybe we can ask claude code to extract info from codebase ?

@github-actions github-actions bot temporarily deployed to pull request November 19, 2025 15:49 Inactive
@github-actions
Copy link
Contributor

@cwickham cwickham changed the base branch from main to prerelease February 23, 2026 20:51
@cwickham cwickham changed the base branch from prerelease to main February 23, 2026 20:52
@github-actions github-actions bot temporarily deployed to pull request February 23, 2026 20:56 Inactive
@github-actions
Copy link
Contributor

@cwickham
Copy link
Collaborator Author

Closing in favor of #1899

@cwickham cwickham closed this Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.4 Changelog Updates: Lua Filters Find homes for changes in 1.4 to LUA and AST

3 participants