Skip to content

Upgrade JS generation for QUDT3 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkleedorfer merged 8 commits into from
Jul 25, 2025
Merged

Upgrade JS generation for QUDT3 #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
55d87aa
Remove special handling for currency units
fkleedorfer Jul 24, 2025
0974293
Upgrade all dependencies
fkleedorfer Jul 24, 2025
7154174
Added concat-files as a submodule
fkleedorfer Jul 24, 2025
0bb5f5c
Add index.d.ts files and adapt to QUDT API changes
fkleedorfer Jul 25, 2025
23cde77
Adapt unit tests
fkleedorfer Jul 25, 2025
63fa910
Format sources
fkleedorfer Jul 25, 2025
bf437b4
Update CHANGELOG.md
fkleedorfer Jul 25, 2025
a79f8f4
Switch to qudtlib-js main branch
fkleedorfer Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions qudtlib-common-codegen/src/main/java/io/github/qudtlib/common/CodeGen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ public static Constant makeConstant(
typeName.substring(0, 1).toLowerCase()
+ typeName.substring(1)
+ "FromLocalnameRequired";
if (typeName.equals("Unit") && codeConstantName.endsWith("_Currency")) {
valueFactory = "currencyFromLocalnameRequired";
}
return new Constant(
codeConstantName, iriLocalName, label, iri, typeName, symbol, valueFactory);
}
Expand Down
2 changes: 1 addition & 1 deletion qudtlib-js
Open in desktop
Submodule qudtlib-js updated from 12abd4 to bf757e
2 changes: 1 addition & 1 deletion qudtlib-main/src/main/java/io/github/qudtlib/Qudt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public static Unit scale(String prefixLabel, String baseUnitLabel) {
// to handle specifically.
if (prefixLabel.toLowerCase(Locale.ROOT).equals("kilo")
&& baseUnitLabel.toLowerCase(Locale.ROOT).equals("gram")) {
return unitFromLabel("kilogram");
return unitFromLocalname("KiloGM");
}
return Optional.empty();
})
Expand Down