Add Iterator.zip #1274
Open
Add Iterator.zip #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
commented
Dec 17, 2025
| @@ -1,10 +1,10 @@ | |||
| ;(function(Array, TypeError, asyncIterator, defineProperty, iterator) { | |||
| ;(function(Array, TypeError, Symbol·asyncIterator, Object·defineProperty, Symbol·iterator) { | |||
| @@ -0,0 +1,210 @@ | |||
| ;(function(IteratorHelper, InternalError, TypeError, call, Symbol·iterator) { | |||
Contributor
Author
There was a problem hiding this comment.
A thing to keep in mind when reviewing this file: it's almost impossible to change or reorder anything here without breaking some test262 tests.
Contributor
|
I'll do a full review shortly, bun in the meantime, some food for thought: do we want to have each of these as a separate file or maybe have a |
Contributor
Author
|
With a single .js file there's no lazy-loading of individual built-ins; it's all or nothing. |
Contributor
Fair enough! |
bnoordhuis
force-pushed
the
iterator-zip-take2
branch
from
cd2a98a to
0ed8683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially tried to do this in C but it was so onerous I decided to switch to JS. Marginally less onerous but still a massive PITA to implement.
Iterator.zipKeyedis up next.