Micro-optimisations to perform better on JSON and String processing #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* free_token is general Javascript deallocation, json_free_token creates a special case with reduced evaluation
Contributor
|
Can you share some before/after performance numbers? I note there are some unrelated changes in your PR. |
Author
|
The focus of this is specifically JSON parsing - Thus I base my work off kraken-1.0/json-parse-financial. I modified the benchmark to run 100x to magnify the impact which is only marginally visible in original. 
|
Author
|
The performance data is in "Instruments" format |
Author
|
I have cleaned up the mix ups with other pieces of code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
free_tokenis general Javascript deallocation,json_free_tokencreates a special case with reduced evaluation for JSON objects