fix: avoid browser tabs content scripts memory leak#864
Merged
Conversation
`browser.runtime.onMessage` listeners seems to prevent content scripts recycle from causing memory leaks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak issue in browser tab content scripts by properly managing event listeners and preventing accumulation of orphaned listeners when tabs become hidden or inactive.
- Adds proper cleanup for runtime message listeners using visibility state tracking
- Implements the
{ once: true }option for one-time event listeners - Manually removes event listeners for document state changes to prevent accumulation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ext/content-scripts/entry-userscripts.js | Adds memory leak prevention through proper event listener cleanup and once-only DOM events |
| src/ext/content-scripts/entry-script-market.js | Implements visibility-based listener management and removes unnecessary variable reset |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #863