refactor(alertsenders): Systray server spawning #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift from conn.Read to io.ReadAll to consume the entire connection data. Also, add diag log messages.
…factoring The default named pipe security descriptor grants full access to LocalSystem account, administrators, and the creator owner.
The systray server is automatically launched when the systray alert sender is enabled. The process is created either via the regular CreateProcess API or CreateProcessAsUser when Fibratus is running inside Windows Service. This requires querying the user token of the currently logged-in console session user. The TCB privilege must be present in the user token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
The systray server is automatically launched when the
systray alert sender is enabled. The process is created
either via the regular
CreateProcessAPI orCreateProcessAsUserwhen Fibratus is running inside Windows Service.
This requires querying the user token of the currently logged-in
console session user. The TCB privilege must be present in the
user token.
What type of change does this PR introduce?
/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)
/kind improvement
Any specific area of the project related to this PR?
/area alertsenders
Special notes for the reviewer
Does this PR introduce a user-facing change?