Skip to content

Conversation

@rabbitstack
Copy link
Owner

@rabbitstack rabbitstack commented Dec 2, 2024

What is the purpose of this PR / why it is needed?

Reduces false positives in the following rules.

  • Thread context set from unbacked memory: include the taskhostw.exe exception
  • Hidden registry key creation: Make sure the callstack contains the *SetValueKey symbol
  • Hidden registry key creation: include explorer.exe exception
  • Potential process injection via tainted memory section: discard all processes from the Program Files/Program Files (x86) directories
  • Script interpreter host or untrusted process persistence: include msedge.exe exceptions

Demotes the severity to medium in the Clear Eventlog rule.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


@rabbitstack rabbitstack force-pushed the reduce-rule-false-positives-pt2 branch from 4ad6544 to 8163dd3 Compare December 4, 2024 19:20
Changeset:

- Thread context set from unbacked memory: include the taskhostw.exe exception
-  Hidden registry key creation: Make sure the callstack contains the *SetValueKey symbol
- Clear Eventlog: Demote severity to medium and exclude the system process
- Hidden registry key creation: include explorer.exe exception
- Potential process injection via tainted memory section: discard all processes from the Program Files/Program Files (x86) directories
- Script interpreter host or untrusted process persistence: include msedge.exe exceptions
@rabbitstack rabbitstack merged commit 20f4386 into master Dec 4, 2024
6 checks passed
@rabbitstack rabbitstack deleted the reduce-rule-false-positives-pt2 branch December 4, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants