Skip to content

fix(pe): Erratic driver identification #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rabbitstack merged 1 commit into from
Mar 17, 2025
Merged

fix(pe): Erratic driver identification #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/pe/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,12 @@ func parse(path string, data []byte, options ...Option) (*PE, error) {
// driver samples may not contain an import directory, but section names may
// reveal the PE is a kernel driver.
func (pe *PE) isDriver() bool {
// Prevent false positives such as ntdll.dll
// because it has the PAGE section which is
// driver-typical
if pe.IsDLL {
return false
}
// DIRECTORY_ENTRY_IMPORT may exist, although it may be empty.
// If it imports from "ntoskrnl.exe" or other kernel components it should
// be a driver.
Expand Down