[POC] Try removing all dev dependencies #709

santib · 2025-12-30T17:22:59Z

santib · 2026-01-05T16:00:35Z

spec/acceptance/allow2ban_spec.rb

-    Rack::Attack.blocklist("allow2ban pentesters") do |request|
-      Rack::Attack::Allow2Ban.filter(request.ip, maxretry: 2, findtime: 30, bantime: 60) do
-        request.path.include?("scarce-resource")
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:01:09Z

spec/acceptance/blocking_ip_spec.rb


-describe "Blocking an IP" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:01:15Z

spec/acceptance/blocking_spec.rb

-  before do
-    Rack::Attack.blocklist do |request|
-      request.ip == "1.2.3.4"
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:01:25Z

spec/acceptance/blocking_subnet_spec.rb


-describe "Blocking an IP subnet" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:04:52Z

spec/acceptance/customizing_throttled_response_spec.rb

-describe "Customizing throttled response" do
-  before do
-    Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:05:01Z

spec/acceptance/fail2ban_spec.rb


-describe "fail2ban" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:05:10Z

spec/acceptance/safelisting_ip_spec.rb


-describe "Safelist an IP" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:05:16Z

spec/acceptance/safelisting_spec.rb

-  before do
-    Rack::Attack.blocklist do |request|
-      request.ip == "1.2.3.4"
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:05:25Z

spec/acceptance/safelisting_subnet_spec.rb


-describe "Safelisting an IP subnet" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:05:35Z

spec/acceptance/throttling_spec.rb


-describe "#throttle" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:05:43Z

spec/acceptance/track_spec.rb


-describe "#track" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:05:49Z

spec/acceptance/track_throttle_spec.rb


-describe "#track with throttle-ish options" do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:06:01Z

spec/allow2ban_spec.rb

-        get '/', {}, 'REMOTE_ADDR' => '1.2.3.4'
-
-        _(last_response.status).must_equal 200
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:06:10Z

spec/fail2ban_spec.rb

-
-    Rack::Attack.blocklist('pentest') do |req|
-      Rack::Attack::Fail2Ban.filter(req.ip, @f2b_options) { req.query_string =~ /OMGHAX/ }
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:08:01Z

spec/rack_attack_throttle_spec.rb

-    Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new
-    Rack::Attack.throttle('ip/sec', limit: 1, period: @period) { |req| req.ip }
-  end
+if defined?(::ActiveSupport::Cache::MemoryStore)


these tests shouldn't be tied to active support

santib · 2026-01-05T16:08:13Z

spec/rack_attack_track_spec.rb


-describe 'Rack::Attack.track' do
-  let(:notifications) { [] }
+if defined?(::ActiveSupport::Notifications)


these tests shouldn't be tied to active support

santib changed the title ~~Try removing all dev dependencies~~ [POC] Try removing all dev dependencies Dec 30, 2025

Try removing all dev dependencies

197bec6

santib force-pushed the try-removing-dev-deps branch from 56eaaca to 62a0e32 Compare January 5, 2026 15:21

Fix tests

47610c3

santib force-pushed the try-removing-dev-deps branch from 62a0e32 to 47610c3 Compare January 5, 2026 15:25

santib added 4 commits January 5, 2026 12:36

Fix rubocop

5375791

Fix Dalli3

4c67647

Fix ConnectionPool issue

12e7fc9

Fix requires order

8c257ba

santib force-pushed the try-removing-dev-deps branch from 3bc94cb to 8c257ba Compare January 5, 2026 15:59

santib commented Jan 5, 2026

View reviewed changes

[POC] Try removing all dev dependencies #709

Are you sure you want to change the base?

[POC] Try removing all dev dependencies #709

Uh oh!

Conversation

santib commented Dec 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant