Compile time check implementation#131
Open
tommymchugh wants to merge 4 commits intoracket:masterfrom
tommymchugh:check-compile-time-exn
Open
Compile time check implementation#131tommymchugh wants to merge 4 commits intoracket:masterfrom tommymchugh:check-compile-time-exn
tommymchugh wants to merge 4 commits intoracket:masterfrom
tommymchugh:check-compile-time-exn
Conversation
…e-time-exn and check-not-compile-time-exn
sorawee
reviewed
Jan 4, 2021
| In the latter case, the exception raised must be an @racket[exn:fail?]. | ||
| } | ||
|
|
||
| @defform[(check-compile-time-exn (expr (-> any))) |
Contributor
There was a problem hiding this comment.
Typo. Should be check-not-compile-time-exn.
sorawee
reviewed
Jan 4, 2021
| [(_ expr:expr) | ||
| #:with loc (datum->syntax #f 'loc stx) | ||
| #'(let ([location (syntax->location #'loc)]) | ||
| (with-check-info (['name 'check-compile-time-exn] |
Author
There was a problem hiding this comment.
Thanks! These should be fixed now.
Member
|
This looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated implementation from #114.
Resolves racket/racket#2996
Adds:
check-compile-time-exn
check-not-compile-time-exn
Comments and thoughts welcome!