fix buffers array in _unlink, add unlink test#18
Open
sethvincent wants to merge 1 commit intorandom-access-storage:masterfrom
Open
fix buffers array in _unlink, add unlink test#18sethvincent wants to merge 1 commit intorandom-access-storage:masterfrom
sethvincent wants to merge 1 commit intorandom-access-storage:masterfrom
Conversation
sethvincent
commented
Nov 14, 2023
| _unlink (req) { | ||
| this._buffers = [] | ||
| this.buffers = [] | ||
| this.length = 0 |
Author
There was a problem hiding this comment.
I was wondering for a bit if pageSize should also be reset here but I guess it makes sense for it to keep its initial value from the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix and test for resetting the
.buffersproperty in_unlink.