Fix scene_render Test and Camera::TakeScreenshot #5
Conversation
This commit addresses two issues: 1. The `scene_render` test was crashing due to a segmentation fault. This was caused by the test attempting to perform OpenGL operations without a valid OpenGL context. The fix involves initializing GLFW and creating a hidden window to provide the necessary context. The makefile has also been updated to link against the GLFW library. 2. The `Camera::TakeScreenshot` function was implemented but contained several errors. It used an incorrect enum for `glGetIntegerv` and passed invalid enums for the pixel format and type to `glReadPixels`. These have been corrected to use the proper OpenGL constants, and the corresponding wrapper functions in `GraphicsHelpers.h` have been updated to accept `GLenum` directly. The necessary OpenGL constants have been defined in `InternalGLloader.h`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This submission fixes a crash in the
scene_rendertest and corrects the implementation of theCamera::TakeScreenshotfunction.PR created automatically by Jules for task 17648837849977211206 started by @randomnumgen1