Fix Camera Projection and View Matrix Calculation #6
Conversation
- Modified `Camera::RenderStart` to accept window dimensions, allowing for correct viewport and aspect ratio calculation. - The projection matrix is now correctly calculated based on the window's aspect ratio. - The view matrix is now correctly calculated from the camera's transform, instead of being hardcoded. - Updated the `Scene::Run` method to pass window dimensions to the camera. - Updated the `scene_render` test to pass the window dimensions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change fixes a rendering issue where the projection and view matrices for the camera were not being calculated correctly. The
Camera::RenderStartmethod has been updated to accept window dimensions, which are now used to correctly calculate the viewport and aspect ratio for the projection matrix. The view matrix calculation has also been corrected to use the camera's transform, rather than hardcoded values. TheScene::Runmethod and thescene_rendertest have been updated to provide the necessary window dimensions.PR created automatically by Jules for task 10419925179086934310 started by @randomnumgen1