Fix default scrollTo in Focused mode#1094
Open
colvinco wants to merge 1 commit intorapi-doc:masterfrom
Open
Conversation
I noticed a regression when upgrading from 9.3.2, in focused mode previously the page would default scroll to the `Overview` when no `#` route is provided. The getElementId changes for rapi-doc#852 meant that when no route is provided, the entire url would be returned, where previously an empty/undefined value would be used and hit https://github.com/rapi-doc/RapiDoc/blob/7f53d25959e5a4e1beb4b610aaef445b896838f2/src/rapidoc.js#L808-L814 - which doesn't happen when the url is returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a regression when upgrading from 9.3.2, in focused mode previously the page would default scroll to the
Overviewwhen no#route is provided.The getElementId changes for #852 meant that when no route is provided, the entire url would be returned, where previously an empty/undefined value would be used and hit:
RapiDoc/src/rapidoc.js
Lines 808 to 814 in 7f53d25