Skip to content

Make driver option required #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rayakame merged 2 commits into from
Dec 10, 2025
Merged

Make driver option required #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9d36d7
work
rayakame Dec 10, 2025
1b54db0
fragment
rayakame Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Breaking-20251210-092132.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Breaking
body: Config option `driver` is now required instead of defaulting to asyncpg
time: 2025-12-10T09:21:32.2253488Z
custom:
Author: rayakame
PR: "138"
2 changes: 2 additions & 0 deletions .changie.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ kinds:
auto: patch
- label: Dependencys
auto: patch
- label: Breaking
auto: patch
newlines:
afterChangelogHeader: 1
beforeChangelogVersion: 1
Expand Down
2 changes: 1 addition & 1 deletion internal/core/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func ParseConfig(req *plugin.GenerateRequest) (*Config, error) {
return nil, fmt.Errorf("unmarshalling plugin options: %w", err)
}
if config.SqlDriver == "" {
config.SqlDriver = SQLDriverAioSQLite
return nil, fmt.Errorf("invalid options: driver must not be empty")
}
val, err := isDriverAsync(config.SqlDriver)
if err != nil {
Expand Down