fix: change env prefix to avoid K8s service env var collision #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change env prefix from FRONTIER to FRONTIER_SERVICE to prevent collision with Kubernetes service environment variables. K8s automatically creates env vars for services (e.g., FRONTIER_APP_PORT for a service named frontier-app). With Viper's FRONTIER prefix, this maps to app.port and overrides config file values with invalid URLs like "tcp://172.20.58.102:80". With FRONTIER_SERVICE prefix, env vars need to be FRONTIER_SERVICE_APP_PORT to affect app.port, avoiding the collision. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 20915422591Details
💛 - Coveralls |
rohilsurana
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change env prefix from
FRONTIERtoFRONTIER_SERVICEto prevent collision with Kubernetes service environment variables.Problem
Kubernetes automatically creates environment variables for services. For a service named
frontier-app, K8s creates:With Viper's
FRONTIERprefix,FRONTIER_APP_PORTmaps toapp.portand overrides config file values. This causes errors like:Solution
Change env prefix to
FRONTIER_SERVICE. Now env vars need to beFRONTIER_SERVICE_APP_PORTto affectapp.port, avoiding the collision with K8s-generated env vars.Breaking Change
Existing deployments using env vars with
FRONTIER_prefix will need to update toFRONTIER_SERVICE_prefix. However, most K8s deployments use config files via-cflag, so impact should be minimal.