Skip to content

refactor: deprecate org_id in billing account CRUD RPCs #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohilsurana wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: deprecate org_id in billing account CRUD RPCs #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 36 additions & 9 deletions raystack/frontier/v1beta1/frontier.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1920,7 +1920,10 @@ message GetBillingAccountRequest {
// ID of the billing account to get
string id = 1 [(validate.rules).string.min_len = 1];

string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from billing account id

bool with_payment_methods = 3;

Expand All @@ -1944,7 +1947,10 @@ message UpdateBillingAccountRequest {
// ID of the billing account to update
string id = 1 [(validate.rules).string.uuid = true];

string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from billing account id

// Billing account to update.
BillingAccountRequestBody body = 3;
Expand All @@ -1959,7 +1965,10 @@ message RegisterBillingAccountRequest {
// ID of the billing account to register
string id = 1 [(validate.rules).string.uuid = true];

string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from billing account id
}

message RegisterBillingAccountResponse {}
Expand All @@ -1980,23 +1989,32 @@ message DeleteBillingAccountRequest {
// ID of the billing account to delete
string id = 1 [(validate.rules).string.uuid = true];

string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from billing account id
}

message DeleteBillingAccountResponse {}

message EnableBillingAccountRequest {
// ID of the billing account to enable
string id = 1 [(validate.rules).string.uuid = true];
string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from billing account id
}

message EnableBillingAccountResponse {}

message DisableBillingAccountRequest {
// ID of the billing account to disable
string id = 1 [(validate.rules).string.uuid = true];
string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from billing account id
}

message DisableBillingAccountResponse {}
Expand All @@ -2005,7 +2023,10 @@ message GetBillingBalanceRequest {
// ID of the billing account to get the balance for
string id = 1 [(validate.rules).string.uuid = true];

string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from billing account id
}

message GetBillingBalanceResponse {
Expand All @@ -2015,9 +2036,15 @@ message GetBillingBalanceResponse {

message HasTrialedRequest {
// ID of the billing account to check
string id = 1 [(validate.rules).string.uuid = true];
string id = 1 [
deprecated = true,
(validate.rules).string.uuid = true
]; // DEPRECATED: billing_id will be inferred from plan_id

string org_id = 2 [(validate.rules).string.min_len = 1];
string org_id = 2 [
deprecated = true,
(validate.rules).string.min_len = 1
]; // DEPRECATED: org_id will be inferred from plan_id

// ID of the plan to check
string plan_id = 3 [(validate.rules).string.min_len = 1];
Expand Down
Loading