Draft
Conversation
- Added 'subtitle' to the feed fields array in lib/fields.js - Added 'subtitle?: string' to the Output interface in index.d.ts This allows the parser to extract the <subtitle> element from RSS/Atom feeds. Co-authored-by: openhands <openhands@all-hands.dev>
Owner
Author
|
@OpenHands add tests for the new subtitle field |
|
I'm on it! rbren can track my progress at all-hands.dev |
- Add support for parsing subtitle from Atom feeds in buildAtomFeed() - Add dedicated test files for subtitle parsing (RSS and Atom) - Update existing test output files to include subtitle field - Add two new test cases: 'should parse subtitle from RSS feed' and 'should parse subtitle from Atom feed' Co-authored-by: openhands <openhands@all-hands.dev>
|
I've successfully added tests for the new subtitle field. Here's a summary of the changes: Changes Made1. Added Atom feed subtitle parsing support (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
subtitlefield to the list of feed fields, allowing the parser to extract the<subtitle>element from RSS/Atom feeds.Changes
lib/fields.js: Added'subtitle'to thefields.feedarrayindex.d.ts: Addedsubtitle?: stringto the TypeScriptOutputinterface for proper type supportTesting
All existing tests pass (38 passing).
@rbren can click here to continue refining the PR