Skip to content

Add subtitle field to feed and item field lists#301

Draft
rbren wants to merge 2 commits intomasterfrom
openhands/add-subtitle-field
Draft

Add subtitle field to feed and item field lists#301
rbren wants to merge 2 commits intomasterfrom
openhands/add-subtitle-field

Conversation

@rbren
Copy link
Owner

@rbren rbren commented Jan 27, 2026

Summary

This PR adds the subtitle field to both the fields.feed and fields.item arrays in lib/fields.js, enabling the RSS parser to extract subtitle information from RSS feeds.

Changes

  • Added subtitle to fields.feed (positioned after description)
  • Added subtitle to fields.item (positioned after title)

Motivation

The subtitle field is commonly used in RSS/Atom feeds but was not being parsed by the library. While the podcast fields already supported itunes:subtitle, the standard subtitle element was missing from the main feed and item field lists.

This allows the parser to extract subtitle information from feeds that include this field.

@rbren
Copy link
Owner Author

rbren commented Jan 27, 2026

@OpenHands add an inline comment describing these changes

@openhands-ai
Copy link

openhands-ai bot commented Jan 27, 2026

I'm on it! rbren can track my progress at all-hands.dev

@openhands-ai
Copy link

openhands-ai bot commented Jan 27, 2026

I've addressed the request to add an inline comment describing the changes in PR #301.

Changes made:

  • Added an inline comment above the subtitle field in lib/fields.js explaining its purpose: // subtitle is commonly used in Atom feeds and some RSS feeds to provide additional context

Checklist:

  • ✅ Added inline comment describing the subtitle field change
  • ✅ Comment is concise and explains why the field is useful
  • ✅ Changes have been committed and pushed to the openhands/add-subtitle-field branch

The PR has been updated with the new commit.

View full conversation

Co-authored-by: openhands <openhands@all-hands.dev>
@rbren rbren force-pushed the openhands/add-subtitle-field branch from 9dc0684 to c3b82f9 Compare February 5, 2026 16:08
@rbren rbren changed the title Add subtitle field to feed fields Add subtitle field to feed and item field lists Feb 5, 2026
@rbren
Copy link
Owner Author

rbren commented Feb 5, 2026

@OpenHands add a test for this case

@openhands-ai
Copy link

openhands-ai bot commented Feb 5, 2026

I'm on it! rbren can track my progress at all-hands.dev

- Add test input file (subtitle.rss) with subtitle fields at both feed and item levels
- Add expected output file (subtitle.json) with parsed subtitle values
- Add test case in parser.js to verify subtitle field parsing
@openhands-ai
Copy link

openhands-ai bot commented Feb 5, 2026

I've added a test for the subtitle field parsing as requested. The changes have been committed and pushed to the openhands/add-subtitle-field branch.

Changes made:

  1. Created test/input/subtitle.rss - An RSS 2.0 test feed with subtitle fields at both the feed level and item level
  2. Created test/output/subtitle.json - The expected parsed output showing the subtitle values
  3. Added a new test case in test/parser.js: 'should parse subtitle field in feed and items'

Test verification:

  • All 39 tests pass, including the new subtitle test
  • The test verifies that:
    • Feed-level subtitle ("Tech insights and tutorials") is correctly parsed
    • Item-level subtitles ("An introduction to our blog" and "More content for readers") are correctly parsed

The PR #301 has been updated with this new commit.

View full conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants