Add subtitle field to feed and item field lists#301
Draft
Conversation
Owner
Author
|
@OpenHands add an inline comment describing these changes |
|
I'm on it! rbren can track my progress at all-hands.dev |
|
I've addressed the request to add an inline comment describing the changes in PR #301. Changes made:
Checklist:
The PR has been updated with the new commit. |
Co-authored-by: openhands <openhands@all-hands.dev>
9dc0684 to
c3b82f9
Compare
Owner
Author
|
@OpenHands add a test for this case |
|
I'm on it! rbren can track my progress at all-hands.dev |
- Add test input file (subtitle.rss) with subtitle fields at both feed and item levels - Add expected output file (subtitle.json) with parsed subtitle values - Add test case in parser.js to verify subtitle field parsing
|
I've added a test for the subtitle field parsing as requested. The changes have been committed and pushed to the Changes made:
Test verification:
The PR #301 has been updated with this new commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
subtitlefield to both thefields.feedandfields.itemarrays inlib/fields.js, enabling the RSS parser to extract subtitle information from RSS feeds.Changes
subtitletofields.feed(positioned afterdescription)subtitletofields.item(positioned aftertitle)Motivation
The subtitle field is commonly used in RSS/Atom feeds but was not being parsed by the library. While the podcast fields already supported
itunes:subtitle, the standard subtitle element was missing from the main feed and item field lists.This allows the parser to extract subtitle information from feeds that include this field.