feat: add showOpenFilePicker method#510
Open
linxianxi wants to merge 1 commit intoreact-component:masterfrom
Open
feat: add showOpenFilePicker method#510linxianxi wants to merge 1 commit intoreact-component:masterfrom
linxianxi wants to merge 1 commit intoreact-component:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
865fd71 to
dc73c0e
Compare
Contributor
Author
|
@afc163 这个 pr 看下 |
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 84.92% 83.98% -0.94%
==========================================
Files 6 6
Lines 252 256 +4
Branches 63 63
==========================================
+ Hits 214 215 +1
- Misses 38 41 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
这个方法不通过 click 行为是调不通的,会引发咨询。 我们不应该提供方法,应该始终让用户手动触发。或者提供原生 input 的获取方式。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
见到挺多人有这样的需求的,比较方便 ant-design/ant-design#41902
叫
showOpenFilePicker是因为 window 下的方法也叫这个like https://github.com/react-dropzone/react-dropzone#using-open-on-click