Fix Android coroutine scope cancellation causing promises to hang after React context reload #911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After React context reload, the document picker's coroutine scope was canceled in
onHostDestroy()but never recreated, causing subsequentlaunch {}calls to silently no-op and promises to never resolve.Changes
Scope lifecycle management:
fileCopyingCoroutinefromvaltovarto allow recreationcreateCoroutineScope(): constructs scope withSupervisorJob() + Dispatchers.IOensureScopeActive(reason): checksscope.isActivebefore launch, recreates if canceledUpdated coroutine launch sites:
processFilePickerResult()(critical path)keepLocalCopy()writeDocuments()Fixes: #907 #910