Update and fix gh actions

[alinkedd]

• Updated external actions to the latest version (except for the upload-artifact). Close Update and fix gh actions #6651
  • upload-artifact was bumped to v3, as I'm not sure about the required unique artifact names in v4, though v3 still uses node16. Also close [Bug]: analyze workflow fails because of deprecated version of actions/upload-artifact #7148
• Fixed the warning of uploading missing files if previous comparing analysis steps were canceled. (As an example, you may check this warning in the annotations section here: https://github.com/reactjs/react.dev/actions/runs/7980888987 or directly in the logs here: https://github.com/reactjs/react.dev/actions/runs/7980888987/job/21791474787 in the Upload analysis comment step)
• Fixed Analyze Bundle (Comment) action failure on the default branch by rewriting the condition, as GitHub's runner evaluation is tricky and sometimes provides false positives. Close [GH workflow] update analyze.yml to avoid noisy notification #5801

NOTE: analyze-comment depends on workflow_run and thus will be used only after merging updates into the default branch. This is why the deprecation warning is still present (https://github.com/reactjs/react.dev/actions/runs/7980542658). To check the proposed fix in a condition, you may look over the same fix in my test repo and then dependant workflow respecting that condition.

Thorough review is welcomed, as I'm no GitHub Actions professional :)

UPD
I added folded block to if condition without expression to shorten the line, and it seems to work file. Links to my latest test results are updated.

UPD 2
#7277 has already updated most of the actions, so it closes #5961 by updating dawidd6/action-download-artifact at last

UPD 3
I've moved fixes to #7667. dawidd6/action-download-artifact should be reworked as part of a different issue

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
19-react-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 4, 2024 10:38pm
react-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 4, 2024 10:38pm

[github-actions]

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[alinkedd]

@gaearon @harish-sethuraman could you please help to find someone to review this PR regarding GH actions? It would be great to have them fixed.

duplicates #6179 (comment)
fyi @rickhanlonii

[alinkedd]

@poteto hi
I noticed you've worked with GitHub Actions. Could you please take a look at this PR as well?

[poteto]

thanks for the contribution! rather than update the existing external action, i would rather we make use of the github ones. could you help rewrite them to use it instead?

[poteto]

do we really need an external action for this? could we rewrite this to use https://github.com/actions/toolkit/tree/main/packages/artifact instead?

[alinkedd]

Sorry for the delayed response

From what I understand, previous versions of actions/download-artifact didn't support retrieving an artifact from a different workflow, but dawidd6/action-download-artifact enabled this via a REST API for downloading.

It now looks like actions/download-artifact@v4 officially supports this feature, so it should be easier to implement that using only the official package.

I'll try to work on this over the weekend

---

UPD actions/download-artifact#3 (comment)

[alinkedd]

@poteto I've completely forgot about this one :) I've moved the fixes to #7667 since they're small and ready to go.

However, I'm not available to work on the improvement of switching from dawidd6/action-download-artifact to the latest version of actions/download-artifact, perhaps it could be converted into a separate issue

[alinkedd]

Close in favor of #7667